Fix opening office documents from webdav network mounts on windows#16739
Merged
Fix opening office documents from webdav network mounts on windows#16739
Conversation
juliusknorr
requested review from
BastienDurel,
georgehrke,
icewind1991 and
rullzer
rullzer
reviewed
Aug 14, 2019
…mpty Bearer header Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
office/head
branch
from
d8716b5 to
fea04ef
Compare
BastienDurel
approved these changes
Aug 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to debug opening office documents from a webdav mounted drive on windows a bit, which prompt for credentials when opening files that are not located in the root folder. This PR at fixes the issue with Windows 10 and current Office 365.
Related previous fix #12556
The following requests happen without that patch applied and
Access log when opening a file in office
/test.docx (works)
/Demo/test.docx (doesn't work)
Office sends OPTIONS/HEAD requests before opening the document with an "Authorization: Bearer" header without a token, which causes an unauthorized response, which when checking for that seems to fix the ever showing credentials dialog. However I still don't get why the request for the file in the root would go to /remote.php/ and works because a 404 is returned 🤷♀️